Preserve type for binary protocol parameters in prepared statements #1081
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Dec 17, 2025
lance6716
approved these changes
Dec 20, 2025
Collaborator
|
Please merge master to meet the merge requirements (somehow I can't push a merge commit from my side) |
ramnes
force-pushed
the
ramnes/typed-bytes
branch
from
031be73 to
0c165f1
Compare
Contributor
Author
|
rebased |
Collaborator
|
Sorry still can't merge after merge 884cd37 maybe this checkbox is not enabled? 
|
ramnes
force-pushed
the
ramnes/typed-bytes
branch
from
0c165f1 to
9996cd4
Compare
Contributor
Author
|
Not sure why you can't update the branch but I can't find the option so I just rebased again, no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
bindStmtArgsparses binary protocol parameters, the MySQL type is available inparamTypes. However, the library loses this type information when passing the parsed values to theHandler.HandleStmtExecutecallback: it converts length-encoded parameters (datetime, varchar, blob, etc.) to plain[]byteand drops the type.This creates problems for proxies: when forwarding these parameters to a backend, the client sees
[]byteand sends them asMYSQL_TYPE_STRING, even if the original type wasMYSQL_TYPE_DATETIMEor another type. Some server implementations strictly validate parameter types and reject this mismatch.This PR introduces a simple
TypedBytesstruct that preserves the original MySQL type alongside the raw bytes.Handler.HandleStmtExecutecallback now receives this struct instead of[]bytefor length-encoded parameters, andclient.Stmtalso handlesTypedBytesby using the preserved type when sending to servers.